Merge lp://staging/~aacid/unity8/tests_wait_time_step into lp://staging/unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Josh Arenson |
| Approved revision: | 2698 |
| Merged at revision: | 2730 |
| Proposed branch: | lp://staging/~aacid/unity8/tests_wait_time_step |
| Merge into: | lp://staging/unity8 |
| Diff against target: |
79 lines (+11/-10) 3 files modified
tests/qmltests/Dash/tst_Dash.qml (+4/-3) tests/qmltests/Launcher/tst_Launcher.qml (+3/-3) tests/utils/modules/Unity/Test/UnityTestCase.qml (+4/-4) |
| To merge this branch: | bzr merge lp://staging/~aacid/unity8/tests_wait_time_step |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Josh Arenson | Approve | ||
| Unity8 CI Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Use timeStep as delay time
Passing iterations / speed didn't make much sense since that parameter is a delay in milliseconds and the default parameters would give a value of 5 / units.gu(10) that is smaller than 1 millisecond.
Qt 5.7 calculation for velocity was very unhappy if we moved things so fast in less than 1ms and ignored the movements, so this also makes tests pass on Qt 5.7
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Josh Arenson (josharenson) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:2697
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/