Merge lp://staging/~aacid/unity8/menuToolBrowser into lp://staging/unity8
Proposed by
Albert Astals Cid
| Status: | Approved |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2893 |
| Proposed branch: | lp://staging/~aacid/unity8/menuToolBrowser |
| Merge into: | lp://staging/unity8 |
| Diff against target: |
172 lines (+60/-31) 5 files modified
plugins/Unity/ApplicationMenu/applicationmenuregistry.cpp (+9/-0) plugins/Unity/ApplicationMenu/applicationmenuregistry.h (+3/-0) tools/menutool/README (+2/-6) tools/menutool/menutool.cpp (+0/-10) tools/menutool/menutool.qml (+46/-15) |
| To merge this branch: | bzr merge lp://staging/~aacid/unity8/menuToolBrowser |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Lukáš Tinkl (community) | Approve | ||
|
Review via email:
|
|||
Commit message
menutool: Use the ApplicationMenu
... instead of asking people to figure out the dbus service manually
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Unmerged revisions
- 2893. By Albert Astals Cid
-
hook up the unregistered signal too
- 2892. By Albert Astals Cid
-
menutool: Use the ApplicationMenu
Registry instead of asking people to figure out the dbus service manually
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:2892
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/