Merge lp://staging/~aacid/unity8/eatHoverWhenLauncherMenuIsOpen into lp://staging/unity8
Proposed by
Albert Astals Cid
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~aacid/unity8/eatHoverWhenLauncherMenuIsOpen |
| Merge into: | lp://staging/unity8 |
| Prerequisite: | lp://staging/~aacid/unity8/eatHoverWhenMenuIsOpen |
| Diff against target: |
67 lines (+27/-1) 3 files modified
qml/Launcher/Launcher.qml (+2/-1) qml/Launcher/LauncherPanel.qml (+3/-0) tests/qmltests/tst_Shell.qml (+22/-0) |
| To merge this branch: | bzr merge lp://staging/~aacid/unity8/eatHoverWhenLauncherMenuIsOpen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Michael Zanetti (community) | Needs Information | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-01-31.
Commit message
Eat hover events when the launcher quicklist is open
This way we don't change the mouse cursor wrongly to resize windows for example
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
Prereq (well probably not really needed, but easier to build on the top of fixes)
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Albert Astals Cid (aacid) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
why do we need two mouse areas with hoverEnabled? Also I'm not sure why the change in Launcher.qml is required.