Merge lp://staging/~aacid/unity/better_build_script into lp://staging/unity/phablet

Proposed by Albert Astals Cid
Status: Merged
Approved by: Nicolas d'Offay
Approved revision: no longer in the source branch.
Merged at revision: 464
Proposed branch: lp://staging/~aacid/unity/better_build_script
Merge into: lp://staging/unity/phablet
Diff against target: 274 lines (+56/-58)
3 files modified
build (+7/-19)
build_unity (+47/-37)
run_on_device (+2/-2)
To merge this branch: bzr merge lp://staging/~aacid/unity/better_build_script
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Omer Akram (community) Approve
Michał Sawicz Needs Information
Nicolas d'Offay (community) Approve
Review via email: mp+153195@code.staging.launchpad.net

Commit message

Easier to use build -s

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

I can vouch for this script.

review: Approve
Revision history for this message
Günter Schwann (schwann) wrote :

When on Raring running it using "./build -s; ./build; ./run", I get the following error on ./run :

ile:///home/schwann/Projects/manhattan/better_build_script/Shell.qml:160:5: Type VolumeControl unavailable
         VolumeControl {
         ^
file:///home/schwann/Projects/manhattan/better_build_script/VolumeControl.qml:2:1: module "QMenuModel" is not installed
     import QMenuModel 0.1
     ^

Revision history for this message
Albert Astals Cid (aacid) wrote :

running locally on raring still not supported, Saviq working on it

Revision history for this message
Michał Sawicz (saviq) wrote :

Can you check for nux in update_nux / compile_nux? i.e. if you `build_script -s --no-nux`, subsequent calls to build_script should assume you don't want nux.

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) wrote :

This should probably install demo-assets and unity-lens-mock, too?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

With the last commit it should work fine. The only issue I had was that after adding the super-friend ppa a few of the packages were missing since they were required to build HUD.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches