Merge lp://staging/~aacid/unity-notifications/micro_optimizations into lp://staging/unity-notifications
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz |
| Approved revision: | 185 |
| Merged at revision: | 185 |
| Proposed branch: | lp://staging/~aacid/unity-notifications/micro_optimizations |
| Merge into: | lp://staging/unity-notifications |
| Diff against target: |
416 lines (+58/-58) 11 files modified
include/ActionModel.h (+1/-1) include/Notification.h (+12/-12) include/NotificationClient.h (+5/-5) include/NotificationModel.h (+9/-9) include/NotificationServer.h (+4/-4) src/ActionModel.cpp (+1/-1) src/Notification.cpp (+8/-8) src/NotificationClient.cpp (+5/-5) src/NotificationClientPlugin.cpp (+1/-1) src/NotificationModel.cpp (+8/-8) src/NotificationServer.cpp (+4/-4) |
| To merge this branch: | bzr merge lp://staging/~aacid/unity-notifications/micro_optimizations |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Sawicz | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Unity API Team | Pending | ||
|
Review via email:
|
|||
Commit message
Minor optimizations
Pass some values by const & instead of by copy
Don't initialize QStrings with "", the default constructor does the same with less code
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:185
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://