unity-2d

Merge lp://staging/~aacid/unity-2d/panel_disabled_status into lp://staging/unity-2d

panel_disabled_status
Merge into trunk

Proposed by Albert Astals Cid on 2012-05-25

Status:

Merged

Approved by:

Gerry Boland on 2012-06-07

Approved revision:

1111

Merged at revision:

1118

Proposed branch:

lp://staging/~aacid/unity-2d/panel_disabled_status

Merge into:

lp://staging/unity-2d

Diff against target:

72 lines (+16/-2)

4 files modified

libunity-2d-private/src/indicatorentrywidget.cpp (+6/-1)
libunity-2d-private/src/indicatorentrywidget.h (+2/-0)
libunity-2d-private/src/indicatorsmanager.cpp (+4/-1)
tests/manual-tests/panel.txt (+4/-0)

To merge this branch:

bzr merge lp://staging/~aacid/unity-2d/panel_disabled_status

Medium

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
jenkins (community)	continuous-integration		Approve on 2012-05-31
Gerry Boland (community)		2012-05-25	Needs Fixing on 2012-05-28
Review via email: mp+107364@code.staging.launchpad.net

Commit message

[panel] Only obey the click/hover in a menu entry if it is sensitive (i.e. isn't disabled)

Description of the change

[panel] Only obey the click/hover in a menu entry if it is sensitive

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-05-28:

Improvement, yes. But the disabled menubar entry should also be greyed out as it's confusing now.

review: Needs Fixing

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-05-29:

We match Unity design (i.e. they are confusing as hell too) so unless design comes up with a solution i don't think it's up to me or you to decide what to do with coloring.

lp://staging/~aacid/unity-2d/panel_disabled_status updated on 2012-05-29