Merge lp://staging/~aacid/ubuntu-settings-components/remove_StatusIcon into lp://staging/ubuntu-settings-components
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Andrea Cimitan |
| Approved revision: | 156 |
| Merged at revision: | 158 |
| Proposed branch: | lp://staging/~aacid/ubuntu-settings-components/remove_StatusIcon |
| Merge into: | lp://staging/ubuntu-settings-components |
| Diff against target: |
279 lines (+0/-239) 5 files modified
examples/OtherComponents.qml (+0/-29) plugins/Ubuntu/Settings/Components/StatusIcon.qml (+0/-129) plugins/Ubuntu/Settings/Components/qmldir (+0/-1) tests/qmltests/CMakeLists.txt (+0/-1) tests/qmltests/Components/tst_StatusIcon.qml (+0/-79) |
| To merge this branch: | bzr merge lp://staging/~aacid/ubuntu-settings-components/remove_StatusIcon |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Andrea Cimitan (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Remove StatusIcon, we've moved to SDK Icon
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
* If you changed localized strings, has the POT file been updated?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
* Did you perform an exploratory manual test run of the code change and any related functionality?
also checked no other StatusIcon strings present in the code
* Did CI run pass? If not, please explain why.
waiting