qmenumodel

Merge lp://staging/~aacid/qmenumodel/batch_insert_remove_from_menu into lp://staging/qmenumodel

  1. batch_insert_remove_from_menu
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 131
Merged at revision: 129
Proposed branch: lp://staging/~aacid/qmenumodel/batch_insert_remove_from_menu
Merge into: lp://staging/qmenumodel
Diff against target: 334 lines (+84/-44)
5 files modified
libqmenumodel/src/gtk/gtkmenutracker.c (+44/-14)
libqmenumodel/src/gtk/gtkmenutracker.h (+2/-1)
libqmenumodel/src/unitymenumodel.cpp (+21/-18)
libqmenumodel/src/unitymenumodelevents.cpp (+12/-8)
libqmenumodel/src/unitymenumodelevents.h (+5/-3)
To merge this branch: bzr merge lp://staging/~aacid/qmenumodel/batch_insert_remove_from_menu
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Lukáš Tinkl (community) Approve
Review via email: mp+318504@code.staging.launchpad.net

Commit message

Batch add and removes into the model

Works much better with Qt Quick views to have all the insert/removes at once

Description of the change

Batch add and removes into the model

To post a comment you must log in.
lp://staging/~aacid/qmenumodel/batch_insert_remove_from_menu updated
130. By Albert Astals Cid

valign

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Crashes after a few popup menus opened:

http://paste.ubuntu.com/24182582/

review: Needs Fixing
lp://staging/~aacid/qmenumodel/batch_insert_remove_from_menu updated
131. By Albert Astals Cid

Fix c&p, this ref should be unref

Revision history for this message
Albert Astals Cid (aacid) wrote :

> Crashes after a few popup menus opened:
>
> http://paste.ubuntu.com/24182582/

Should be fixed, an ref should had been an unref (meh copy&paste)

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Works fine, no more crashes. I'd like someone with more glib/gobject knowledge to have a look at the code as well though

review: Approve
Revision history for this message
Charles Kerr (charlesk) wrote :

It's a little twisty, but but at the glib/gobject level everything seems to balance out.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches