Merge lp://staging/~aacid/qmenumodel/aboutToShow into lp://staging/qmenumodel

comments inline

I will add all those auto, but those are *totally* not on the style of the rest of the file, basically the file has 0 auto variables.

> You probably meant to use -1 here to use the default timeout? I'm not sure what specifying a timeout of 0msec would do but it's probably not good
No, I don't want the default timeout, i simply want no timeout, it either works or doesn't, i don't see why it's "probably not good" to use a 0 timeout

> Not a blocker, but want to confirm that you meant to not provide a callback here so that you can log any errors reported by g_dbus_connection_call_finish(), yes?
Yes, if you want I can add error reporting, but don't think it's going to give us much tbh.

> I will add all those auto, but those are *totally* not on the style of the
> rest of the file, basically the file has 0 auto variables.

No worries, as I said those were trivial comments. Redundant type info
is bad, but inconsistency is also bad, pick your minor poison :)

> > You probably meant to use -1 here to use the default timeout? I'm not sure
> what specifying a timeout of 0msec would do but it's probably not good
> No, I don't want the default timeout, i simply want no timeout, it either
> works or doesn't, i don't see why it's "probably not good" to use a 0 timeout

Because the docs say use G_MAXINT for no timeout.

g_dbus_connection_call() is in gdbusconnection.c, which the call down a few steps.
The timeout is applied in g_dbus_connection_send_message_with_reply_unlocked(),
which reads:

  if (timeout_msec != G_MAXINT)
    {
      data->timeout_source = g_timeout_source_new (timeout_msec);
      g_task_attach_source (task, data->timeout_source,
                            (GSourceFunc) send_message_with_reply_timeout_cb);
      g_source_unref (data->timeout_source);
    }

I /think/ you are effectively asking the call to timeout asap.

> > Not a blocker, but want to confirm that you meant to not provide a callback
> here so that you can log any errors reported by
> g_dbus_connection_call_finish(), yes?
> Yes, if you want I can add error reporting, but don't think it's going to give
> us much tbh.

Agreed that it's minor.

Keeping as NF for the G_MAXINT issue