overlay-scrollbar

Merge lp://staging/~aacid/overlay-scrollbar/qt_no_overlay_scrollbar into lp://staging/overlay-scrollbar

  1. qt_no_overlay_scrollbar
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp://staging/~aacid/overlay-scrollbar/qt_no_overlay_scrollbar
Merge into: lp://staging/overlay-scrollbar
Diff against target: 26 lines (+8/-0)
1 file modified
os/os-scrollbar.c (+8/-0)
To merge this branch: bzr merge lp://staging/~aacid/overlay-scrollbar/qt_no_overlay_scrollbar
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Andrea Cimitan Disapprove
jenkins (community) continuous-integration Approve
Review via email: mp+124697@code.staging.launchpad.net

Commit message

Use ubuntu_gtk_set_use_overlay_scrollbar and ubuntu_gtk_get_use_overlay_scrollbar so that other programs can say they don't want to use the overlay scrollbars

Description of the change

Use ubuntu_gtk_set_use_overlay_scrollbar and ubuntu_gtk_get_use_overlay_scrollbar so that other programs can say they don't want to use the overlay scrollbars

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:357
http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/./distribution=quantal,flavor=amd64/3/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/./distribution=quantal,flavor=i386/3/console

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

The branch relies on a patch on both gtk2 and qt sides which was supposed to be removed. It is also not fixing the bug on static binaries without the ubuntu qt or gtk libraries.

Thus, this looks more like a possible distropatch than being part of the real code.

At this time, we wait to see if we come up with a clean fix, that does not use external API which we were going to remove.

If we run out of ideas, this is part of the list of workarounds we can add as distropatches.

review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:357
http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/./build=pbuilder,distribution=quantal,flavor=amd64/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ayatana-scrollbar-ci/./build=pbuilder,distribution=quantal,flavor=i386/7/console

review: Needs Fixing (continuous-integration)

Unmerged revisions

357. By Albert Astals Cid

Use ubuntu_gtk_set_use_overlay_scrollbar and ubuntu_gtk_get_use_overlay_scrollbar so that other programs can say they don't want to use the overlay scrollbars

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches