Merge lp://staging/~a1s/brz/3.2-windows-separators into lp://staging/brz/3.2

Proposed by Aleksandr Smyshliaev
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~a1s/brz/3.2-windows-separators
Merge into: lp://staging/brz/3.2
Diff against target: 47 lines (+12/-6)
1 file modified
breezy/ (+12/-6)
To merge this branch: bzr merge lp://staging/~a1s/brz/3.2-windows-separators
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email:

Commit message

Let osutils path functions on Windows accept byte strings as well as unicode strings

Description of the change

As far as I understand, Breezy hasn't decided yet if file paths should be byte strings or Unicode strings. A lot of calls to osutils functions pass byte strings, but the regression tests use mostly Unicode strings.

This change makes osutils accept both bytes and strings, just as posixpath and ntpath from the Standard Library do.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches