Breezy

Merge lp://staging/~a1s/brz/3.2-windows-local-paths into lp://staging/brz/3.2

  1. 3.2-windows-local-paths
  2. Merge into 3.2
Proposed by Aleksandr Smyshliaev
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp://staging/~a1s/brz/3.2-windows-local-paths
Merge into: lp://staging/brz/3.2
Diff against target: 23 lines (+4/-1)
2 files modified
breezy/location.py (+2/-1)
breezy/tests/test_location.py (+2/-0)
To merge this branch: bzr merge lp://staging/~a1s/brz/3.2-windows-local-paths
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+411937@code.staging.launchpad.net

Commit message

Fix: location_to_url didn't call local_path_to_url for plain ASCII paths

On Windows, this produced "ssh:" urls instead of "file:"

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
Revision history for this message
Aleksandr Smyshliaev (a1s) wrote :

The test is https://bugs.launchpad.net/brz/+bug/1951112

Revision history for this message
Jelmer Vernooij (jelmer) :
Revision history for this message
Aleksandr Smyshliaev (a1s) :
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Please add a test in breezy/tests/test_location.py as well?

Revision history for this message
Aleksandr Smyshliaev (a1s) wrote :

> Please add a test in breezy/tests/test_location.py as well?

The test for this is test_location.TestLocationToUrl.test_path, as said in https://bugs.launchpad.net/brz/+bug/1951112

The test is failing without this fix, and passing with it.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> > Please add a test in breezy/tests/test_location.py as well?
>
> The test for this is test_location.TestLocationToUrl.test_path, as said in
> https://bugs.launchpad.net/brz/+bug/1951112
>
> The test is failing without this fix, and passing with it.
It doesn't fail on Linux without this change, and adding a test will help prevent this regressing.

Revision history for this message
Aleksandr Smyshliaev (a1s) wrote (last edit ):

> > The test for this is test_location.TestLocationToUrl.test_path, as said
> > in https://bugs.launchpad.net/brz/+bug/1951112
> >
> > The test is failing without this fix, and passing with it.
>
> It doesn't fail on Linux without this change, and adding a test will help
> prevent this regressing.

Ah, I see. Ok, here it is.

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches