Xfce4 Panel Profiles

Merge lp://staging/~a-j-buxton/xfpanel-switch/missing-source into lp://staging/~xfpanel-switch-dev/xfpanel-switch/trunk

  1. missing-source
  2. Merge into trunk
Proposed by Alistair Buxton
Status: Merged
Merged at revision: 136
Proposed branch: lp://staging/~a-j-buxton/xfpanel-switch/missing-source
Merge into: lp://staging/~xfpanel-switch-dev/xfpanel-switch/trunk
Diff against target: 20 lines (+2/-1)
1 file modified
xfpanel-switch/panelconfig.py (+2/-1)
To merge this branch: bzr merge lp://staging/~a-j-buxton/xfpanel-switch/missing-source
Reviewer Review Type Date Requested Status
Sean Davis Approve
Review via email: mp+343251@code.staging.launchpad.net

Commit message

There are three ways to create a PanelConfig object:

 1. PanelConfig()
 2. PanelConfig.from_xfconf()
 3. PanelConfig.from_file()

The two factory functions set the source attribute on the new object,
but directly calling the constructor did not.

This pair of patches sets source to None in the constructor, and adds
a default value of None when the source is checked.

Fixes LP:1762779.

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

Everything checks out.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches