Unity

Merge lp://staging/~3v1n0/unity/track-more-objects into lp://staging/unity

  1. track-more-objects
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4266
Proposed branch: lp://staging/~3v1n0/unity/track-more-objects
Merge into: lp://staging/unity
Diff against target: 149 lines (+27/-45)
4 files modified
hud/HudController.cpp (+1/-1)
launcher/EdgeBarrierController.cpp (+21/-36)
launcher/EdgeBarrierControllerPrivate.h (+1/-4)
plugins/unityshell/src/unityshell.cpp (+4/-4)
To merge this branch: bzr merge lp://staging/~3v1n0/unity/track-more-objects
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+337402@code.staging.launchpad.net

Commit message

Unity use track_obj to safely connect to UScreen and Settings signals (LP: #1748330)

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

At the moment unity doesn't compile with 2.55.2-1ubuntu1. Is this issue related? See bug 1749957

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Ok. This branch compiles just fine with glib2.0 2.55.2-1ubuntu1. Thanks.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Khurshid, oops. I just did a rebuild of the Bileto ticket but it fails to build. It looks like it fails at a different point though.

https://bileto.ubuntu.com/#/ticket/3138

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.