Merge lp://staging/~3v1n0/unity/scale-close-middle-click into lp://staging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2748
Proposed branch: lp://staging/~3v1n0/unity/scale-close-middle-click
Merge into: lp://staging/unity
Diff against target: 1018 lines (+472/-175)
6 files modified
plugins/unityshell/src/ScreenIntrospection.h (+48/-0)
plugins/unityshell/src/unityshell.cpp (+223/-156)
plugins/unityshell/src/unityshell.h (+23/-19)
tests/autopilot/unity/emulators/screen.py (+42/-0)
tests/autopilot/unity/tests/__init__.py (+12/-0)
tests/autopilot/unity/tests/test_spread.py (+124/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/unity/scale-close-middle-click
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Review via email: mp+126044@code.staging.launchpad.net

Commit message

UnityShell: enable closing on middle-click, fix scaled decoration sizes, fix theming issues, added scale autopilot tests

Description of the change

Improved the computation of an unity scaled window size, so that there won't be drawing issues, updated the corner radius value to match the system default, fix style issues on theme changed. Plus, lots of code cleanup and optimizations.

Added introspection for the UnityScreen and UnityWindows so that we can now use autopilot for them.
So, new AP tests for new scale features.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Code looks good, tests work, bugs look fixed and also works manually :). +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.