Unity

Merge lp://staging/~3v1n0/unity/panelmenu-fixes into lp://staging/unity

panelmenu-fixes
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2011-09-20

Status:

Merged

Merged at revision:

1617

Proposed branch:

lp://staging/~3v1n0/unity/panelmenu-fixes

Merge into:

lp://staging/unity

Diff against target:

1499 lines (+470/-231)

12 files modified

plugins/unityshell/src/PanelIndicatorsView.cpp (+55/-41)
plugins/unityshell/src/PanelIndicatorsView.h (+13/-1)
plugins/unityshell/src/PanelMenuView.cpp (+146/-86)
plugins/unityshell/src/PanelMenuView.h (+9/-7)
plugins/unityshell/src/PanelTitlebarGrabAreaView.cpp (+35/-33)
plugins/unityshell/src/PanelTitlebarGrabAreaView.h (+11/-10)
plugins/unityshell/src/PanelView.cpp (+20/-9)
plugins/unityshell/src/PanelView.h (+3/-0)
plugins/unityshell/src/PluginAdapter.cpp (+33/-1)
plugins/unityshell/src/WindowButtons.cpp (+14/-2)
plugins/unityshell/src/WindowManager.cpp (+5/-1)
services/panel-service.c (+126/-40)

To merge this branch:

bzr merge lp://staging/~3v1n0/unity/panelmenu-fixes

Related bugs:

Bug #736491: Panel Titlebar double click is emitted for any mouse button	Low	Fix Released
Bug #761228: maximising via dragging to panel and unmaximising leaves faded panel title	Low	Fix Released
Bug #774121: Sometimes dragging down from the panel just stops working	Low	Fix Released
Bug #781215: Windows cannot be dragged down from panel if banshee closed to sound menu	Medium	Fix Released
Bug #820293: application's menu shown when the cursor is a little left to window controls	Undecided	Fix Released
Bug #823353: Window buttons in the panel have no indication of the "pressed" form	Low	Fix Released
Bug #825230: Re-maximizing a window doesn't correctly maximize it again	Undecided	Invalid
Bug #834065: Impossible to navigate between panel menus when the mouse cursor is over the panel	Medium	Fix Released
Bug #835637: Window buttons and application menu don't autohide if left edge is touched	Low	Fix Released
Bug #838021: After double clicking on the panel to restore a window, the menus won't be hidden on mouse-out	Undecided	Fix Released
Bug #838479: After restoring a window the application title doesn't fade-out and it goes below the menus	Undecided	Fix Released
Bug #838759: window title should not appear until cursor leaves the menubar	Low	Fix Released
Bug #838923: Start dragging a maximized application title causes it to re-decorate	Medium	Fix Released
Bug #839488: Window title is not redrawn on leaving global-menu from buttons	Low	Fix Released
Bug #843670: Activating a menu item or clicking outside area menu doesn't hide the application menu	Low	Fix Released
Bug #844309: Using menus with only one click doesn't work as expected	Low	Fix Released
Bug #845772: Showing menu of a maximized application via dragging needs an extra movement	Low	Fix Released
Bug #845774: Restored windows dragged down from the panel still shows their menu	Low	Fix Released
Bug #855521: alt-tab - When the ALT key is pressed, there should be a very short delay before the app menu is exposed in the top bar	Medium	Fix Released
Bug #858815: Panel shouldn't be dragged when the dash is showing	Undecided	Fix Released

Link a bug report

Reviewer	Date Requested	Status
Neil J. Patel (community)	2011-09-20	Approve on 2011-09-26
Jason Smith (community)	2011-09-20	Approve on 2011-09-24
Gord Allott (community)		Approve on 2011-09-23
Review via email: mp+76133@code.staging.launchpad.net

Description of the change

Fixed lots of other PanelMenuView related bugs (see the linked list of "In Progress bugs" for reference).

In particular, I've also changed these things:
- Moving to nux::GetGraphicsDisplay()->GetMouseScreenCoord() (instead of gdk functions,
warning this needs nux bzr-453 or newer not to crash, thanks to Jay for fixing!)
- Checking for mouse position after closing menus to hide/show them (bug bug #843670)
- Checking for mouse position after dragging a window to to hide/show menus
- Fix for PluginAdapter not to consider unmapped windows as maximized (bug #781215)
- Panel-service: correctly close menus when releasing mouse outside a menu title (bug #844309)
- Panel-service: cache the indicator entries geometry and use the values for checking mouse position
- Don't redecorate windows on maximization drag (bug #838923)
- panel-service: Remove id2entry_hash and use sscanf to parse the entries IDs
- PanelView: track mouse position only when it has been changed (fix bug #834065)
- PanelMenuView / PanelIndicatorsView: remove code duplication for adding an entry
- Better mouse grab management using only PanelTitleGrabArea
- PanelMenuView: even more checks to avoid to show/hide menus when we shouldn't
- PanelView: sync geometries for real

See the related commit logs for more informations.

This branch, to work properly, needs the updated UnityCore code that I've pushed in my lp:~3v1n0/unity/menus-switching-hacks branch (for the entries geometry things), so in the case that the other branch isn't accepted, we need to port its UnityCore changes here.

PS: for the record, this is the previous merge request for this branch: https://code.launchpad.net/~3v1n0/unity/panelmenu-fixes/+merge/73622