Unity

Merge lp://staging/~3v1n0/unity/neko-reloaded into lp://staging/unity

  1. neko-reloaded
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 4227
Proposed branch: lp://staging/~3v1n0/unity/neko-reloaded
Merge into: lp://staging/unity
Diff against target: 170 lines (+50/-6)
6 files modified
dash/DashView.cpp (+24/-0)
dash/DashView.h (+1/-0)
dash/ResultRendererTile.cpp (+17/-4)
dash/ResultRendererTile.h (+3/-1)
dash/ScopeView.cpp (+4/-1)
dash/ScopeView.h (+1/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/unity/neko-reloaded
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Ted Gould (community) Approve
Charles Kerr (community) Approve
Brandon Schaefer (community) Approve
Omer Akram (community) qa Approve
Neil J. Patel (community) Approve
Gord Allott (community) best review Approve
Iain Lane (community) Approve
Review via email: mp+322219@code.staging.launchpad.net

Commit message

Dash: fix the neko regression we have since a couple of cycles

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Yep!

review: Approve
Revision history for this message
Gord Allott (gordallott) wrote :

you star

review: Approve (best review)
Revision history for this message
Neil J. Patel (njpatel) wrote :

Excellent work!

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks "fathers", it means a lot! :-D

PS: Yeah, launcher is missing, too bad it was FF coming.

Revision history for this message
Omer Akram (om26er) wrote :

Works as expected, I must add.

review: Approve (qa)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Im sorry we had to remove this from U7, must approve

review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

You guys rock, thanks for all the hard work you've put into this.

Revision history for this message
Charles Kerr (charlesk) wrote :

This is the only remaining feature we needed. Guys, we can all go home now

review: Approve
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Michal Hruby (mhr3) wrote :

😱 oh dear, how did I miss this? Definitely 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.