Unity

Merge lp://staging/~3v1n0/unity/lockscreen-review into lp://staging/unity

lockscreen-review
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2014-03-06

Status:

Merged

Merged at revision:

3703

Proposed branch:

lp://staging/~3v1n0/unity/lockscreen-review

Merge into:

lp://staging/unity

Prerequisite:

lp://staging/~azzar1/unity/lockscreen

Diff against target:

1793 lines (+533/-291)

32 files modified

UnityCore/DBusIndicators.cpp (+2/-2)
UnityCore/GnomeSessionManager.cpp (+12/-7)
UnityCore/GnomeSessionManager.h (+1/-0)
UnityCore/SessionManager.h (+2/-1)
debian/control (+1/-5)
lockscreen/BackgroundSettings.cpp (+78/-41)
lockscreen/BackgroundSettings.h (+8/-8)
lockscreen/LockScreenAbstractShield.h (+55/-0)
lockscreen/LockScreenController.cpp (+91/-57)
lockscreen/LockScreenController.h (+10/-6)
lockscreen/LockScreenShield.cpp (+81/-25)
lockscreen/LockScreenShield.h (+11/-16)
lockscreen/LockScreenShieldFactory.cpp (+2/-5)
lockscreen/LockScreenShieldFactory.h (+4/-8)
lockscreen/UserAuthenticator.h (+6/-6)
lockscreen/UserAuthenticatorPam.cpp (+14/-12)
lockscreen/UserAuthenticatorPam.h (+1/-2)
lockscreen/UserPromptView.cpp (+67/-33)
lockscreen/UserPromptView.h (+3/-3)
lockscreen/pch/lockscreen_pch.hh (+6/-2)
plugins/unityshell/src/unityshell.cpp (+10/-1)
plugins/unityshell/unityshell.xml.in (+1/-1)
po/POTFILES.in (+1/-0)
services/panel-main.c (+2/-2)
tests/data/external.gschema.xml (+18/-0)
tests/test_lockscreen_controller.cpp (+10/-7)
tests/test_text_input.cpp (+0/-2)
unity-shared/IMTextEntry.cpp (+3/-2)
unity-shared/IMTextEntry.h (+1/-4)
unity-shared/TextInput.cpp (+25/-24)
unity-shared/TextInput.h (+4/-6)
unity-shared/UScreen.cpp (+3/-3)

To merge this branch:

bzr merge lp://staging/~3v1n0/unity/lockscreen-review

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrea Azzarone (community)			Needs Fixing on 2014-03-07
Brandon Schaefer (community)		2014-03-06	Approve on 2014-03-07
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-03-06
Review via email: mp+209796@code.staging.launchpad.net

Commit message

Lockscreen: Multimonitor support, use greeter settings and don't paint popup windows

In detail:
- Use proper fonts for text input
- Make text cursor to blink as expected
   (needs lp:~3v1n0/nux/textentry-toggle-cursor-visibility)
- Use bullet as password char
- Support multi-monitor correctly, switching view on mouse movement (as the greeter
   does)
- Fixed lockscreen not showing on newly attached monitors
- Never paint windows that might popup under the lockscreen (such as tooltips or
   notifications)
- Use unity greeter gsettings values for painting the Background (support color, or
   disable user bg)
- Don't lock guest sessions

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-06:

FAILED: Continuous integration, rev:3732
http://jenkins.qa.ubuntu.com/job/unity-ci/766/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/302/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/298/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/300/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/766/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Brandon Schaefer (brandontschaefer) wrote on 2014-03-07:

Code looks good to me, and unit tests are passing :)

review: Approve

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2014-03-07:

1070 - auto* tmp_response = static_cast<pam_response*>(malloc(num_msg * sizeof(pam_response)));
1071 + auto* tmp_response = g_new0(pam_response, num_msg);

Please revert. Pam specs says that you need to can use just malloc. I know that internall g_new0 uses it but we don't know in future.

review: Needs Fixing