Merge lp://staging/~3v1n0/unity/launcher-dragwindow-ordering-rewrite into lp://staging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Brandon Schaefer |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2644 |
| Proposed branch: | lp://staging/~3v1n0/unity/launcher-dragwindow-ordering-rewrite |
| Merge into: | lp://staging/unity |
| Prerequisite: | lp://staging/~3v1n0/unity/launchers-setup-struts |
| Diff against target: |
185 lines (+61/-59) 2 files modified
launcher/Launcher.cpp (+48/-53) manual-tests/Launcher.txt (+13/-6) |
| To merge this branch: | bzr merge lp://staging/~3v1n0/unity/launcher-dragwindow-ordering-rewrite |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Launcher: make always possible to drag an icon to the bottom or top of its sublist
It was not possible before to reorder application icons below the BFB or above the workspace switcher
Description of the change
The code to reorder icons when one was dragged was messy and bugged, so I've rewritten it to improve it and to fix some issues that made impossible (for example) to re-order an icon at the end or at the bottom of an icons sublist (i.e. a list of icons of the same type).
Manual tests updated.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Awesome, now works :).