Merge lp://staging/~3v1n0/unity/icon-dragging-cancels-on-windows-mapping into lp://staging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2652
Proposed branch: lp://staging/~3v1n0/unity/icon-dragging-cancels-on-windows-mapping
Merge into: lp://staging/unity
Diff against target: 161 lines (+37/-32)
6 files modified
launcher/Launcher.cpp (+2/-24)
launcher/Launcher.h (+0/-3)
launcher/LauncherDragWindow.cpp (+12/-4)
launcher/LauncherDragWindow.h (+1/-0)
tests/test_launcher.cpp (+1/-1)
tests/test_launcher_drag_window.cpp (+21/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/unity/icon-dragging-cancels-on-windows-mapping
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+122392@code.staging.launchpad.net

Commit message

LauncherDragWindow: cancel drag on window mapped/unmapped

Description of the change

Make sure that an icon dragged from the launcher emits a drag-cancel signal when a window is mapped/unmapped.

unit tests added.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.