unity-lens-files

Merge lp://staging/~3v1n0/unity-lens-files/show-folder-select into lp://staging/unity-lens-files

  1. show-folder-select
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 248
Merged at revision: 247
Proposed branch: lp://staging/~3v1n0/unity-lens-files/show-folder-select
Merge into: lp://staging/unity-lens-files
Diff against target: 22 lines (+5/-4)
1 file modified
src/daemon.vala (+5/-4)
To merge this branch: bzr merge lp://staging/~3v1n0/unity-lens-files/show-folder-select
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+148462@code.staging.launchpad.net

Commit message

Daemon: select target file when Showing in their folder.

Description of the change

Launch the filemanager with the target file as parameter when showing it in its folder, so that the filemanager will select it.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

5 var path = GLib.Path.get_dirname (uri);

Could you please remove this line, it's not needed anymore.

Apart from that it looks good and works as advertised, thanks!

review: Needs Fixing
lp://staging/~3v1n0/unity-lens-files/show-folder-select updated
248. By Marco Trevisan (Treviño)

Damon: The path variable is not needed anymore

Cleaning up...

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ops... Sorry, thanks for pointing out.

Fixed! ;)

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches