Unity Control Center

Merge lp://staging/~3v1n0/unity-control-center/grouped-compiz-gsettings-support-x into lp://staging/unity-control-center/16.04

grouped-compiz-gsettings-support-x
Merge into 16.04

Proposed by Marco Trevisan (Treviño) on 2017-06-27

Status:

Superseded

Proposed branch:

lp://staging/~3v1n0/unity-control-center/grouped-compiz-gsettings-support-x

Merge into:

lp://staging/unity-control-center/16.04

Diff against target:

723 lines (+371/-83)

2 files modified

debian/changelog (+7/-0)
panels/appearance/cc-appearance-panel.c (+364/-83)

To merge this branch:

bzr merge lp://staging/~3v1n0/unity-control-center/grouped-compiz-gsettings-support-x

Related bugs:

Bug #1700600: Appearance settings changed in normal mode, aren't properly updated when using low-gfx (and vice-versa)	Medium	Fix Released
Bug #1705063: Reset behavior settings wrongly add the "show-desktop" icon to the launcher	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Unity Control Center development team		2017-06-27	Pending
Review via email: mp+326366@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2017-07-04.

Commit message

Appearance: create GroupedGSettings class to manage group of gsettings sharing the schema

Settings might have the same schema, but different path. With this class we manage them
all at once. In this case we use this to correctly read the setting values depending on
the compiz profile we're actually using.

lp://staging/~3v1n0/unity-control-center/grouped-compiz-gsettings-support-x updated on 2017-11-30

12866. By Marco Trevisan (Treviño) on 2017-07-06

GroupedGSettings: ensure we ref the variant's before setting them

Otherwise when we set floating references they get consumed
by the first call to g_settings_set_value and the value becomes
invalid. Thus we need to remove the floating reference, and
manually ref and unref.

12867. By Marco Trevisan (Treviño) on 2017-07-06