Ubuntu One Client

Merge lp://staging/~3v1n0/ubuntuone-client/sync-menu-use-gappinfo-launch-4.2 into lp://staging/ubuntuone-client/stable-4-2

sync-menu-use-gappinfo-launch-4.2
Merge into stable-4-2

Proposed by Marco Trevisan (Treviño) on 2013-04-16

Status:

Rejected

Rejected by:

dobey on 2014-01-09

Proposed branch:

lp://staging/~3v1n0/ubuntuone-client/sync-menu-use-gappinfo-launch-4.2

Merge into:

lp://staging/ubuntuone-client/stable-4-2

Diff against target:

352 lines (+205/-48)

2 files modified

tests/platform/sync_menu/test_linux.py (+139/-20)
ubuntuone/platform/sync_menu/linux.py (+66/-28)

To merge this branch:

bzr merge lp://staging/~3v1n0/ubuntuone-client/sync-menu-use-gappinfo-launch-4.2

Related bugs:

Bug #627195: Window management - Apps raised from indicators sometimes dont have the focus	Undecided	Fix Committed
Bug #1168175: Opening the "Ubuntu One folder" from indicator-sync doesn't bring nautilus to focus	Medium	Fix Released

Link a bug report

Reviewer	Date Requested	Status
dobey (community)	2013-04-16	Disapprove on 2014-01-09
Diego Sarmentero	2013-04-16	Pending
Review via email: mp+159190@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-04-12.

Commit message

UbuntuOneSyncMenuLinux: use GAppInfo with proper context to launch URIs

This allows to correctly open the application with proper startup notify.

Description of the change

Backport of lp:~3v1n0/ubuntuone-client/sync-menu-use-gappinfo-launch to 4.2 stable branch.

Revision history for this message

Diego Sarmentero (diegosarmentero) wrote on 2013-04-12: Posted in a previous version of this proposal

Tests are failing, and there isn't new tests for the new code.

review: Needs Fixing

Revision history for this message

dobey (dobey) wrote on 2013-04-12: Posted in a previous version of this proposal

I'm just rejecting this, because it's not necessary to have to deal with 2 proposals at the moment. Only the branch against truck is needed for this, as there's no conflicting difference between it and stable-4-2 that would break this branch.

review: Disapprove

Revision history for this message

dobey (dobey) wrote on 2014-01-09:

Just going to reject this now, as the 4.2 branch is what is in Ubuntu 13.04, which is going EOL this month, so we won't be pushing an update to it.

review: Disapprove