Merge lp://staging/~3v1n0/ubuntuone-client/mnemonics-files-fix into lp://staging/ubuntuone-client

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: dobey
Approved revision: 1404
Merged at revision: 1403
Proposed branch: lp://staging/~3v1n0/ubuntuone-client/mnemonics-files-fix
Merge into: lp://staging/ubuntuone-client
Diff against target: 44 lines (+14/-2)
2 files modified
tests/platform/sync_menu/test_linux.py (+12/-0)
ubuntuone/platform/sync_menu/linux.py (+2/-2)
To merge this branch: bzr merge lp://staging/~3v1n0/ubuntuone-client/mnemonics-files-fix
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve
dobey (community) Approve
Review via email: mp+194560@code.staging.launchpad.net

Commit message

LinuxSyncMenu: Sanitize the menu entries by replacing one underscore character into two.

This makes libdbusmenu happy and show it as a single underscore instead that as a mnemonic
character.

Description of the change

LibDBusMenu internally treats strings with one underscore char as mnemonics, this won't happens when adding two underscores.

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Looks ok to me.

review: Approve
Revision history for this message
Mike McCracken (mikemc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches