Merge lp://staging/~3v1n0/ubuntu-ui-toolkit/slotslayout-paddings-changes-updates-size into lp://staging/ubuntu-ui-toolkit/staging
| Status: | Merged |
|---|---|
| Approved by: | Andrea Bernabei |
| Approved revision: | 2135 |
| Merged at revision: | 2132 |
| Proposed branch: | lp://staging/~3v1n0/ubuntu-ui-toolkit/slotslayout-paddings-changes-updates-size |
| Merge into: | lp://staging/ubuntu-ui-toolkit/staging |
| Diff against target: |
84 lines (+55/-2) 2 files modified
src/UbuntuToolkit/ucslotslayout.cpp (+4/-2) tests/unit/visual/tst_slotslayout.13.qml (+51/-0) |
| To merge this branch: | bzr merge lp://staging/~3v1n0/ubuntu-ui-toolkit/slotslayout-paddings-changes-updates-size |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve | |
| Andrea Bernabei (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-09-27.
Commit message
UCSlotsLayout: update the size of the element when top/bottom paddings change
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yep
* Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes, tested with testcase too:
https:/
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed the packaging (debian), did you subscribe a core-dev to this MP?
N/A
| Andrea Bernabei (faenil) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
| Timo Jyrinki (timo-jyrinki) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
thanks for the MR! I left a comment :)