Ubuntu theme

Merge lp://staging/~3v1n0/ubuntu-themes/cosmic-fixes into lp://staging/ubuntu-themes

cosmic-fixes
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2018-10-03

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2018-10-04

Approved revision:

635

Merged at revision:

627

Proposed branch:

lp://staging/~3v1n0/ubuntu-themes/cosmic-fixes

Merge into:

lp://staging/ubuntu-themes

Diff against target:

368 lines (+154/-16)

9 files modified

Ambiance/gtk-3.20/apps/chromium.css (+4/-0)
Ambiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Ambiance/gtk-3.20/gtk-main.css (+1/-0)
Ambiance/gtk-3.20/gtk-widgets.css (+49/-6)
Radiance/gtk-3.20/apps/chromium.css (+4/-0)
Radiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-0)
Radiance/gtk-3.20/gtk-widgets.css (+51/-8)
debian/changelog (+24/-0)

To merge this branch:

bzr merge lp://staging/~3v1n0/ubuntu-themes/cosmic-fixes

Related bugs:

Bug #1743373: Combobox arrow and color are inverted	Medium	Fix Released
Bug #1758841: virt-manager: Light grey menu items on light grey background are barely readable	Low	Invalid
Bug #1761684: Regression in lists like gnome-boxes	Low	Fix Released
Bug #1781736: Buttons aren't properly themed in Radiance theme under HiDPI	Medium	In Progress
Bug #1782038: Window buttons are small in a maximized Chromium window	Medium	Fix Released
Bug #1785699: Invisible text in insenstitive suggested action buttons	Medium	Fix Released
Bug #1795895: Accelerators on selected menu-items are not readable	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrea Azzarone (community)		2018-10-03	Approve on 2018-10-05
Review via email: mp+356072@code.staging.launchpad.net

Commit message

Ambiance, Radiance: improve theming as per bionic reviews and bug reports

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2018-10-04:

> Ambiance, Radiance: use default disabled color for actions headerbar buttons (LP: #1743373)

The bug number seems incorrect. Can you please fix this and also link the bug to the MR?

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2018-10-04:

Once fixed it looks good to me.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2018-10-04:

Thanks for spotting, fixed now.

Actual bug I wanted to link was https://launchpad.net/bugs/1785699

lp://staging/~3v1n0/ubuntu-themes/cosmic-fixes updated on 2018-10-05

635. By Marco Trevisan (Treviño) on 2018-10-03: debian/changelog: sync with bzr changes
636. By Marco Trevisan (Treviño) on 2018-10-05: Radiance: Use scaled image for buttons border