Merge lp://staging/~3v1n0/libappindicator/incons-paths-on-snap-xenial into lp://staging/libappindicator/16.04

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 275
Merged at revision: 274
Proposed branch: lp://staging/~3v1n0/libappindicator/incons-paths-on-snap-xenial
Merge into: lp://staging/libappindicator/16.04
Diff against target: 339 lines (+139/-11)
2 files modified
example/simple-client-vala.vala (+1/-1)
src/app-indicator.c (+138/-10)
To merge this branch: bzr merge lp://staging/~3v1n0/libappindicator/incons-paths-on-snap-xenial
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+316972@code.staging.launchpad.net

Commit message

AppIndicator: fix icon and theme paths when running in $SNAP environment

Prepend $SNAP path to icons and theme paths when running in a sandboxed
environment, this allows to run app indicators without caring about the fact
they've been designed or compiled to run in a snap world or not.

Description of the change

Backported commit from upstream

To post a comment you must log in.
274. By Marco Trevisan (Treviño)

AppIndicator: fix icon and theme paths when running in environment

Prepend path to icons and theme paths when running in a sandboxed
environment, this allows to run app indicators without caring about the fact
they've been designed or compiled to run in a snap world or not.

275. By Marco Trevisan (Treviño)

AppIndicator: don't emit label changes when guide is empty (and not null)

Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM

review: Approve
276. By Marco Trevisan (Treviño)

app-indicator: don't append the snap prefix if the icon is saved in a well known readable path

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches