libappindicator

Merge lp://staging/~3v1n0/libappindicator/g-ir-scanner-docs into lp://staging/libappindicator

  1. g-ir-scanner-docs
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Ted Gould
Approved revision: 219
Merged at revision: 213
Proposed branch: lp://staging/~3v1n0/libappindicator/g-ir-scanner-docs
Merge into: lp://staging/libappindicator
Prerequisite: lp://staging/~3v1n0/libappindicator/secondary-activate-support
Diff against target: 1387 lines (+490/-492)
3 files modified
src/Makefile.am (+1/-0)
src/app-indicator.c (+350/-353)
src/app-indicator.h (+139/-139)
To merge this branch: bzr merge lp://staging/~3v1n0/libappindicator/g-ir-scanner-docs
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+68560@code.staging.launchpad.net

Description of the change

When compiling libappindicator you get some g-ir-scanner warnings:

 GISCAN AppIndicator3-0.1.gir
 app-indicator.h:299: Warning: AppIndicator3: app_indicator_get_menu: return value: Missing (transfer) annotation
 app-indicator.h:303: Warning: AppIndicator3: app_indicator_get_secondary_activate_target: return value: Missing (transfer) annotation

This is due to the fact that the app-indicator.c is not scanned and the comments there don't use a syntax that the scanner recognize... This branch fixes this issue, moving all the GTK-doc comments to the standard syntax.

PS: As important side-effect of this warning, the mentioned functions aren't (were not) available in gir based bindings such as Vala.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Sucks that g-ir-scanner can only use that format as I like the other one better :-) Thanks for converting everything!

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Eh, unfortunately that's the only format that it seems to recognize, but to get nice bindings with low effort this is the way to write comments! :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches