Merge lp://staging/~3v1n0/indicator-sound/gtk-application-player-activate into lp://staging/indicator-sound/13.04
Status: | Merged |
---|---|
Approved by: | Lars Karlitski |
Approved revision: | 347 |
Merged at revision: | 346 |
Proposed branch: | lp://staging/~3v1n0/indicator-sound/gtk-application-player-activate |
Merge into: | lp://staging/indicator-sound/13.04 |
Prerequisite: | lp://staging/~3v1n0/indicator-sound/launch-context |
Diff against target: |
191 lines (+131/-4) 5 files modified
src/Makefile.am (+2/-1) src/gtk-application-player.vala (+123/-0) src/metadata-menu-item.vala (+2/-1) src/mpris2-controller.vala (+2/-2) src/player-controller.vala (+2/-0) |
To merge this branch: | bzr merge lp://staging/~3v1n0/indicator-sound/gtk-application-player-activate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Lars Karlitski (community) | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2013-04-02.
Commit message
PlayerController use GtkApplicationP
GtkApplicationP
It allows to check if the given player implements the "org.gtk.
and if it's the case, it Activate the application with the proper timestamp when
requested.
Description of the change
Add a GtkApplicationP
This fixes bug #627195 for some applications such as Rhythmbox.
Unfortunately the proper fix would need to change the MPRIS interface. See https:/
PASSED: Continuous integration, rev:347 jenkins. qa.ubuntu. com/job/ indicator- sound-ci/ 13/ jenkins. qa.ubuntu. com/job/ indicator- sound-raring- amd64-ci/ 2 jenkins. qa.ubuntu. com/job/ indicator- sound-raring- armhf-ci/ 2
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ indicator- sound-ci/ 13/rebuild
http://