Merge lp://staging/~3v1n0/indicator-sound/bamf-player-activation into lp://staging/indicator-sound/13.10
| Status: | Merged |
|---|---|
| Approved by: | Lars Karlitski |
| Approved revision: | 351 |
| Merged at revision: | 347 |
| Proposed branch: | lp://staging/~3v1n0/indicator-sound/bamf-player-activation |
| Merge into: | lp://staging/indicator-sound/13.10 |
| Prerequisite: | lp://staging/~3v1n0/indicator-sound/gtk-application-player-activate |
| Diff against target: |
243 lines (+100/-19) 6 files modified
configure.ac (+2/-0) debian/control (+1/-0) src/Makefile.am (+3/-1) src/metadata-menu-item.vala (+1/-1) src/player-activator.vala (+91/-15) src/player-controller.vala (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~3v1n0/indicator-sound/bamf-player-activation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Lars Karlitski (community) | Approve | ||
|
Review via email:
|
|||
Commit message
PlayerActivator: Use BAMF to find the windows to activate with timestamp
Improved the"old" GtkApplicationP
activate an application's windows. Basically we try to get the windows of the
selected application and when found we focus them using the activation
timestamp.
Description of the change
Upstream port of lp:~3v1n0/indicator-sound/bamf-player-activation/+merge/156920
Added a new fallback method to focus the windows of the player that we need to raise using the event timestamp, if we're not using a GtkApplication based player, we try to get the player windows from Bamf.
At that point we can focus them with the activation event timestamp.
This will work well for banshee, Spotify, Youtube and any other local or web-player.
I've added a new dependency to libbamf3. If this is a problem for packaing stuff, I can provide a version that uses bamf directly via DBus, but I'd really prefer to use the library.
| PS Jenkins bot (ps-jenkins) wrote | # |
| Unity Merger (unity-merger) wrote | # |
Approved, same as the one merged in 13.04.