GNOME Shell

Merge lp://staging/~3v1n0/gnome-shell/bionic-patches-picks into lp://staging/~ubuntu-desktop/gnome-shell/ubuntu

  1. bionic-patches-picks
  2. Merge into ubuntu
Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 143
Proposed branch: lp://staging/~3v1n0/gnome-shell/bionic-patches-picks
Merge into: lp://staging/~ubuntu-desktop/gnome-shell/ubuntu
Diff against target: 1534 lines (+1455/-1)
13 files modified
debian/changelog (+26/-0)
debian/patches/StIcon-only-compute-shadow-pipeline-when-the-texture-is-p.patch (+134/-0)
debian/patches/js-fix-invalid-access-errors.patch (+564/-0)
debian/patches/popupMenu-Fix-wrong-call-to-clutter_actor_add_child.patch (+28/-0)
debian/patches/series (+12/-1)
debian/patches/shell-ignore-invalid-window-monitor-index.patch (+98/-0)
debian/patches/st-texture-cache-Cancel-sliced-image-loading-on-target-ac.patch (+118/-0)
debian/patches/st-texture-cache-Don-t-add-NULL-textures-to-cache.patch (+92/-0)
debian/patches/volume-Add-back-sound-feedback-on-scroll.patch (+106/-0)
debian/patches/workspace-fix-repositioned-windows-in-activities.patch (+148/-0)
debian/patches/workspaceThumbnail-initialize-porthole-based-on-workArea.patch (+36/-0)
debian/patches/workspaceThumbnail-only-update-_porthole-if-the-overview-.patch (+29/-0)
debian/patches/workspaceThumbnail-rebuild-thumbnails-if-workareas-size-c.patch (+64/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/gnome-shell/bionic-patches-picks
Reviewer Review Type Date Requested Status
Jeremy Bícha Approve
Review via email: mp+343423@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I am very concerned with the decision to add 11 more patches to bionic's gnome-shell. I am concerned that this could make updating to 3.28.2 difficult (or the 3.30 series) if too much code is changed before these patches are accepted in to GNOME.

You could at least help reduce this number by following up on the patches that have already been applied to upstream master to see if they can be pushed to the gnome-3-28 branch.

Please also try to be more persistent with getting upstream review of the remaining patches.

I encourage you to talk to Debian's smcv to see if he would be interested in taking some of these patches in to Debian.

One minor note. The patch rename wasn't done in this merge proposal. Maybe that was missed when exporting your work from git.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

2018-04-17 13:15 GMT-05:00 Jeremy Bicha <email address hidden>:
> I am very concerned with the decision to add 11 more patches to bionic's gnome-shell. I am concerned that this
> could make updating to 3.28.2 difficult (or the 3.30 series) if too much code is changed before these patches
> are accepted in to GNOME.

Considering how the pace at gnome-shell development is currently, I
think this won't be really a problem.
Plus, I've linked the git repo I've used to generate all this, and
using patch-queue, you know that rebasing won't really be an issue.
In any, case I can take care of it. Although I hope some of these
patch will merge (where's it's not already the case).

> You could at least help reduce this number by following up on the patches that have already been applied to upstream master
> to see if they can be pushed to the gnome-3-28 branch.

There's not gnome-3-28 branch yet, thus everything that here has been
cherry-picked from master, will be in 3.28.X.

> Please also try to be more persistent with getting upstream review of the remaining patches.

Eh, true, but I also don't like to bother people :).

> I encourage you to talk to Debian's smcv to see if he would be interested in taking some of these patches in to Debian.

Yeah, I already planned to propose some of them to salsa too.

> One minor note. The patch rename wasn't done in this merge proposal. Maybe that was missed when exporting your work from git.

Oh, well spotted. Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches