Compiz

Merge lp://staging/~3v1n0/compiz/decor-size-adjustments-disable into lp://staging/compiz/0.9.11

  1. decor-size-adjustments-disable
  2. Merge into 0.9.11
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Christopher Townsend
Approved revision: 3814
Merged at revision: 3815
Proposed branch: lp://staging/~3v1n0/compiz/decor-size-adjustments-disable
Merge into: lp://staging/compiz/0.9.11
Diff against target: 54 lines (+2/-18)
2 files modified
src/privatewindow.h (+0/-1)
src/window.cpp (+2/-17)
To merge this branch: bzr merge lp://staging/~3v1n0/compiz/decor-size-adjustments-disable
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Christopher Townsend (community) Approve
Review via email: mp+201435@code.staging.launchpad.net

Commit message

Window: disable the size adjustments when decorating/undecorating windows.

Description of the change

Don't apply any size adjustment after setting/unsetting the decoration extents
as they seem to cause more troubles than gains.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3814
http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-ci/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-amd64-ci/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-armhf-ci/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-i386-ci/16/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-0.9.11-ci/16/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

LGTM. Better to revert this since it causes too many headaches.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-autolanding/21/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-amd64-autolanding/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-armhf-autolanding/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-0.9.11-trusty-i386-autolanding/21/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3861

review: Needs Fixing (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

So it seems something (not this MP most likely) has broken the build:

The following tests FAILED:
 1064 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestSetValueOnWrapper (SEGFAULT)
 1065 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetValueOnWrapper (SEGFAULT)
 1066 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestResetKeyOnWrapper (SEGFAULT)
 1067 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestListKeysOnWrapper (SEGFAULT)
 1068 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetSchemaName (SEGFAULT)
 1069 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetPath (SEGFAULT)
 1070 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestConnectToChangedSignal (SEGFAULT)
 1074 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorTest.TestWrapperConstructionWithPath (SEGFAULT)
 1075 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorTest.TestGetGSettingsWrapper (SEGFAULT)

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

The problem there is that there's a gsettings path which is invalid -
have a look in the logs for where it should be fixed (easily done).

Note: When testing this fix, please also make sure that guake still
works (that's the application I fixed by putting this one in in the
first place).

On Mon, Jan 13, 2014 at 6:22 PM, Christopher Townsend
<email address hidden> wrote:
> So it seems something (not this MP most likely) has broken the build:
>
> The following tests FAILED:
> 1064 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestSetValueOnWrapper (SEGFAULT)
> 1065 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetValueOnWrapper (SEGFAULT)
> 1066 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestResetKeyOnWrapper (SEGFAULT)
> 1067 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestListKeysOnWrapper (SEGFAULT)
> 1068 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetSchemaName (SEGFAULT)
> 1069 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestGetPath (SEGFAULT)
> 1070 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorAutoInitTest.TestConnectToChangedSignal (SEGFAULT)
> 1074 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorTest.TestWrapperConstructionWithPath (SEGFAULT)
> 1075 - CCSGSettingsWrapperWithMemoryBackendEnvGoodAllocatorTest.TestGetGSettingsWrapper (SEGFAULT)
> --
> https://code.launchpad.net/~3v1n0/compiz/decor-size-adjustments-disable/+merge/201435
> Your team Compiz Maintainers is subscribed to branch lp:compiz.

--
Sam Spilsbury

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> Note: When testing this fix, please also make sure that guake still
> works (that's the application I fixed by putting this one in in the
> first place).

Thanks for pointing it out, but it seems that guake is working properly now.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Awesome, we can drop this hack then :)

On Mon, Jan 13, 2014 at 9:36 PM, Marco Trevisan (Treviño)
<mail@3v1n0.net> wrote:
>> Note: When testing this fix, please also make sure that guake still
>> works (that's the application I fixed by putting this one in in the
>> first place).
>
> Thanks for pointing it out, but it seems that guake is working properly now.
> --
> https://code.launchpad.net/~3v1n0/compiz/decor-size-adjustments-disable/+merge/201435
> Your team Compiz Maintainers is subscribed to branch lp:compiz.

--
Sam Spilsbury

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches