Merge lp://staging/~3v1n0/bamf/create-local-desktop into lp://staging/bamf

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Christopher Townsend
Approved revision: 645
Merged at revision: 572
Proposed branch: lp://staging/~3v1n0/bamf/create-local-desktop
Merge into: lp://staging/bamf
Diff against target: 1319 lines (+731/-51)
23 files modified
debian/libbamf3-1.symbols (+1/-0)
lib/libbamf-private/org.ayatana.bamf.view.xml (+3/-0)
lib/libbamf-private/org.ayatana.bamf.xml (+8/-1)
lib/libbamf/bamf-application.c (+21/-0)
lib/libbamf/bamf-application.h (+3/-2)
lib/libbamf/bamf-control.c (+31/-5)
lib/libbamf/bamf-control.h (+4/-0)
lib/libbamf/bamf-tab-source.c (+1/-1)
src/bamf-application.c (+272/-2)
src/bamf-application.h (+2/-0)
src/bamf-control.c (+45/-8)
src/bamf-control.h (+3/-0)
src/bamf-legacy-window-test.c (+2/-2)
src/bamf-legacy-window.c (+20/-17)
src/bamf-legacy-window.h (+5/-3)
src/bamf-matcher.c (+27/-2)
src/bamf-matcher.h (+2/-0)
src/bamf-tab.c (+2/-4)
src/bamf-unity-webapps-application.c (+10/-1)
src/bamf-unity-webapps-observer.c (+0/-1)
tests/bamfdaemon/test-application.c (+220/-2)
tests/bamfdaemon/test-bamf.c (+12/-0)
tests/bamfdaemon/test-matcher.c (+37/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/bamf/create-local-desktop
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Pending
Review via email: mp+178794@code.staging.launchpad.net

Commit message

BamfControl: add an API to allow generation of local .desktop file for a BamfApplication.

Add a bamf_control dbus method that requests to generate a new local .desktop
file for the provided application path. In case the application has alredy
a desktop file, the request is ignored. Otherwise we use some euristic to
generate an hopefully valid file saved in $XDG_DATA_HOME dir.

Also added a new DesktopUpdated signal to the BamfApplication DBus interface
that is emitted when the .desktop file for an application is set (for now).

Description of the change

Add a bamf_control dbus method that requests to generate a new local .desktop
file for the provided application path. In case the application has alredy
a desktop file, the request is ignored. Otherwise we use some euristic to
generate an hopefully valid file saved in $XDG_DATA_HOME dir.

Also added a new DesktopUpdated signal to the BamfApplication DBus interface
that is emitted when the .desktop file for an application is set (for now).

All the dbus changes have been reflected to the libbamf API.
New unit tests added.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
645. By Marco Trevisan (Treviño)

debian: update libbamf3-1 symbols file

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

Merges and builds cleanly and all tests new and old pass. Code looks good.

I did not try the actual creating the desktop file since that is done by https://code.launchpad.net/~3v1n0/unity/desktop-file-updated-support/+merge/178703. I will review that MP and see if the .desktop file gets created and that the actual bug is fixed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches