Autopilot

Merge lp://staging/~3v1n0/autopilot/badwindow-errors-protect into lp://staging/autopilot

  1. badwindow-errors-protect
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Needs review
Proposed branch: lp://staging/~3v1n0/autopilot/badwindow-errors-protect
Merge into: lp://staging/autopilot
Diff against target: 24 lines (+5/-2)
1 file modified
autopilot/process/_bamf.py (+5/-2)
To merge this branch: bzr merge lp://staging/~3v1n0/autopilot/badwindow-errors-protect
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Approve
Andrea Azzarone (community) Approve
prod-platform-qa continuous-integration Pending
Review via email: mp+268467@code.staging.launchpad.net

Commit message

Bamf: protect from BadWindow errors when getting the title

A bamf window might be still on bus, but actually closed at X level,
so we must protect from errors when trying to fetch properties.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM

review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:569
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1131/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/61
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/61/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/60
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/60/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/61
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/61/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3799
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3122
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3796
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3796/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22672

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1131/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Christopher Lee (veebers) wrote :

This looks good to me, but I believe this is for the Unity test cases? If so this should be against https://code.launchpad.net/~autopilot/autopilot/legacy (autopilot-legacy, autopilot-desktop-legacy) which is under the stewardship of the Unity7 team.

Reply
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok thanks for pointing out.

It's still to keep track of this on trunk until there will X11 support btw.

Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/1/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/1/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/119/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/353/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/351/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1829/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/119/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/128/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/382/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/380/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1868/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/128/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/137/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/413/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/413/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1910/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/137/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/146/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/441/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/441/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1942/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/146/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:569
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/155/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/455/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/455/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1959/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/155/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

569. By Marco Trevisan (Treviño)

Bamf: protect from BadWindow errors when getting the title

A bamf window might be still on bus, but actually closed at X level,
so we must protect from errors when trying to fetch properties.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches