Merge lp://staging/~3v1n0/autopilot/badwindow-errors-protect-legacy into lp://staging/autopilot/legacy

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: 498
Merged at revision: 498
Proposed branch: lp://staging/~3v1n0/autopilot/badwindow-errors-protect-legacy
Merge into: lp://staging/autopilot/legacy
Diff against target: 149 lines (+34/-30)
6 files modified
autopilot/process/_bamf.py (+30/-6)
autopilot/tests/unit/test_platform.py (+2/-2)
autopilot/tests/unit/test_testresults.py (+1/-1)
bin/autopilot-sandbox-run (+1/-2)
debian/patches/sandbox_run_exit.patch (+0/-18)
debian/patches/series (+0/-1)
To merge this branch: bzr merge lp://staging/~3v1n0/autopilot/badwindow-errors-protect-legacy
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Autopilot Hackers Pending
Review via email: mp+268995@code.staging.launchpad.net

Commit message

Bamf: protect from BadWindow errors when getting the title

A bamf window might be still on bus, but actually closed at X level,
so we must protect from errors when trying to fetch properties.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve
499. By Marco Trevisan (Treviño)

tests: fix failing unit tests

500. By Martin Pitt

Fix autopilot3-sandbox-run exit status.

If autopilot fails with a non-zero exit code, capture this in $RC, instead of
capturing the exit status of "echo" (which will always succeed).

501. By Marco Trevisan (Treviño)

debian: remove downstream patches, as they're merged now

502. By Marco Trevisan (Treviño)

Bamf: avoid to crash on __repr__ because of unreachable view

503. By Marco Trevisan (Treviño)

Bamf: set proper __eq__ and __neq__ operators

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches