Merge ~2bdkid/ubuntu/+source/ubiquity:fix-1396379 into ubuntu/+source/ubiquity:ubuntu/devel

Proposed by Brady Dean
Status: Needs review
Proposed branch: ~2bdkid/ubuntu/+source/ubiquity:fix-1396379
Merge into: ubuntu/+source/ubiquity:ubuntu/devel
Diff against target: 28 lines (+9/-0)
2 files modified
debian/changelog (+8/-0)
ubiquity/plugins/ubi-partman.py (+1/-0)
Reviewer Review Type Date Requested Status
Łukasz Zemczak (community) packaging Needs Fixing
git-ubuntu import Pending
Review via email: mp+432828@code.staging.launchpad.net

Description of the change

set the partman-auto/disk question to the selected bootloader install device so partman will select an EFI partition from only that device.

To post a comment you must log in.
Revision history for this message
Brady Dean (2bdkid) wrote :

To reproduce the original bug you need 2 hard drives present, with one pre-formatted with an EFI partition. Select for ubuntu to be installed onto the second hard drive, and select it as the bootloader install device. You'll notice that the EFI partition from the first drive is mounted to /target/boot/efi instead of the EFI partition from the second drive.

I applied this change in the 20.10 live installer and found it correctly mounted the EFI partition from the second drive.

Revision history for this message
Ubfan (ubfan1) wrote :

The second drive may also be an USB stick. The mount to /target/boot/efi occurs early in the install process, so it may be quickly determined if the patch works, mounting the ESP from the target USB.

Revision history for this message
Brady Dean (2bdkid) wrote :

It's unfortunate that this option is not given explicitly to partman in the same way it is to grub-installer.

Is there some other special handling for USB targets? I'm short on USB drives otherwise I'd give it a try.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thank you for the merge proposal! As I can't really properly review the change per-se (even though it seems at least going in the right direction, but I'd like someone to confirm that this does what is expected first), I'll only comment on the debian/ parts for now.

The branch needs to be rebased to the latest devel branch. Also, we don't really do +nmuX versioning in Ubuntu. Please bump it to the next available version for the selected series.

review: Needs Fixing (packaging)
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

But yes, before we can proceed at all, I'd like someone to run some tests on this.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches