Merge lp://staging/~274914765-t/terminator/terminator into lp://staging/terminator/trunk
Proposed by
274914765@qq.com
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~274914765-t/terminator/terminator |
| Merge into: | lp://staging/terminator/trunk |
| Diff against target: |
426 lines (+94/-42) 5 files modified
terminatorlib/config.py (+8/-7) terminatorlib/preferences.glade (+49/-15) terminatorlib/prefseditor.py (+13/-5) terminatorlib/terminator.py (+4/-2) terminatorlib/window.py (+20/-13) |
| To merge this branch: | bzr merge lp://staging/~274914765-t/terminator/terminator |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen Boddy | Needs Fixing | ||
| 274914765@qq.com | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-01-19.
Description of the change
add center support for the config option of position
To post a comment you must log in.
Revision history for this message
| 274914765@qq.com (274914765-t) wrote | # |
Unmerged revisions
- 1712. By 274914765@qq.com
-
provide chinese support for the config option of show_on_center
- 1711. By 274914765@qq.com
-
merges branch
- 1710. By 274914765@qq.com
-
add a config option: show_on_center, provide a GUI way for the user who wants to set window position
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
From a quick look, this is incomplete. There is no GUI way for the user to set this value. If I've understood correctly I'd have to edit the config by hand. Which is fine until I save another setting, and the "position=center" entry gets overwritten... so I change it by hand again... and so on.
Also you are using a text editor that automatically trims whitespace. Unless submitting a change specifically to fix whitespace, please try to avoid including those, as they just add noise (not a problem here, but best to be consistent :-)