Charm Helpers

Merge lp://staging/~2-xtian/charm-helpers/application-version-set into lp://staging/charm-helpers

  1. application-version-set
  2. Merge into devel
Proposed by Christian Muirhead
Status: Rejected
Rejected by: Stuart Bishop
Proposed branch: lp://staging/~2-xtian/charm-helpers/application-version-set
Merge into: lp://staging/charm-helpers
Diff against target: 34 lines (+24/-0)
1 file modified
charmhelpers/core/hookenv.py (+24/-0)
To merge this branch: bzr merge lp://staging/~2-xtian/charm-helpers/application-version-set
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Disapprove
Review via email: mp+300183@code.staging.launchpad.net

Commit message

Add charmhelpers.core.hookenv.application_version_set as a convenience wrapper for the application-version-set command. If it's not available, then it falls back to logging the version instead.

Juju 2.0-beta12 adds the application-version-set hook tool that lets a charm tell Juju which version of the charmed software is running. This displayed in the status info for the application, which means that charm authors won't need to jam it into status messages.

Description of the change

Add charmhelpers.core.hookenv.application_version_set as a convenience wrapper for the application-version-set command. If it's not available, then it falls back to logging the version instead.

Juju 2.0-beta12 adds the application-version-set hook tool that lets a charm tell Juju which version of the charmed software is running. This displayed in the status info for the application, which means that charm authors won't need to jam it into status messages.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

A similar branch got landed, adding core.hookenv.application_version_set()

review: Disapprove

Unmerged revisions

602. By Christian Muirhead

Undo inadvertent change to license text

601. By Christian Muirhead

Add core.hookenv.application_version_set

This calls the application-version-set hook tool to tell juju what
version of the charmed software is running, which will be displayed in
status. If the application-version-set command doesn't exist it logs
the version instead.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches