Merge lp://staging/~1vd1jn0oc/indicator-power/primary-battery-fix into lp://staging/~jjardon/indicator-power/master
Status: | Rejected |
---|---|
Rejected by: | Javier Jardón |
Proposed branch: | lp://staging/~1vd1jn0oc/indicator-power/primary-battery-fix |
Merge into: | lp://staging/~jjardon/indicator-power/master |
Diff against target: |
24 lines (+3/-3) 1 file modified
src/indicator-power.c (+3/-3) |
To merge this branch: | bzr merge lp://staging/~1vd1jn0oc/indicator-power/primary-battery-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Disapprove | ||
Javier Jardón | Pending | ||
Review via email: mp+86340@code.staging.launchpad.net |
Description of the change
Changes the method of determining the primary battery device from the device that has the least time left in terms of charge remaining, to the one with the most. I personally don't care if my tiny second battery has run down if the big main one has 3 hours left on it. Alternatives would be to show charge level as a sum of all devices or display a meter for each device present. This being a ~12 character patch is a good start IMO.
Unmerged revisions
- 124. By David Schlenk <email address hidden>
-
Instead of picking the primary battery device by which has the least time
left in terms of charge remaining, pick the one with the most. I don't care
if my tiny second battery has run down if the big main one has 3 hours left
on it. YMMV.
Hm, on the one hand, I like this patch. On the other hand, the design spec's update now details what we should do when >1 battery is present, and this patch doesn't follow the spec any more than the current behavior does.