Merge lp://staging/~11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount/ubuntu/karmic/graphviz/fix-bug-376400 into lp://staging/ubuntu/karmic/graphviz

Proposed by No
Status: Merged
Merged at revision: not available
Proposed branch: lp://staging/~11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount/ubuntu/karmic/graphviz/fix-bug-376400
Merge into: lp://staging/ubuntu/karmic/graphviz
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount/ubuntu/karmic/graphviz/fix-bug-376400
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+11588@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
No (11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

This fixes bug 376400.

29. By No

Rename because this has been fixed upstream

30. By No

Use fix from Graphviz 2.24.0, tag the patch and update the changelog timestamp

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-07-28 18:49:03 +0000
3+++ debian/changelog 2009-09-10 16:04:44 +0000
4@@ -1,3 +1,10 @@
5+graphviz (2.20.2-3ubuntu5) karmic; urgency=low
6+
7+ * debian/patches/30_fix_dot2gxl_segfault:
8+ - Fix a segfault in dot2gxl (LP: #376400)
9+
10+ -- Simon Olofsson <simon@olofsson.de> Thu, 10 Sep 2009 18:01:41 +0200
11+
12 graphviz (2.20.2-3ubuntu4) karmic; urgency=low
13
14 * No change rebuild against current OCaml. (LP: #405286)
15
16=== added file 'debian/patches/30_fix_dot2gxl_segfault'
17--- debian/patches/30_fix_dot2gxl_segfault 1970-01-01 00:00:00 +0000
18+++ debian/patches/30_fix_dot2gxl_segfault 2009-09-10 16:04:44 +0000
19@@ -0,0 +1,13 @@
20+Index: graphviz/cmd/tools/dot2gxl.c
21+===================================================================
22+--- graphviz.orig/cmd/tools/dot2gxl.c 2009-09-10 17:54:08.867377820 +0200
23++++ graphviz/cmd/tools/dot2gxl.c 2009-09-10 17:54:46.302150365 +0200
24+@@ -646,7 +646,7 @@
25+ char *val;
26+
27+ val = agget(e, name);
28+- if (val[0]) {
29++ if (val != NULL) {
30+ tabover(gxlFile);
31+ fprintf(gxlFile, "\t<attr name=\"%s\">\n", name);
32+ tabover(gxlFile);
33
34=== modified file 'debian/patches/series'
35--- debian/patches/series 2008-11-05 09:54:54 +0000
36+++ debian/patches/series 2009-09-10 16:04:44 +0000
37@@ -4,3 +4,4 @@
38 #0_libtool_linking_reorder_workaround
39 10_fix_tred_regression
40 20_fix_parser_stack_overflow
41+30_fix_dot2gxl_segfault

Subscribers

People subscribed via source and target branches

to all changes: