Author: Oliver Calder
Author Date: 2023-10-19 17:08:28 UTC

o/state: set `noticeCond` correctly in `ReadState`

This corresponds to an upstream fix in pebble:
https://github.com/canonical/pebble/pull/320

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-30 05:46:58 UTC

tests/nested/core: add nested spread test for setting EFI vars

The test checks that EFI boot variables exist for the following:
1. A Boot#### variable pointing to the shim file path.
2. A BootOrder variable with the #### from the above Boot#### as first.

Since the layout of EFI assets is dependent on the gadget snap, the test
downloads and unpacks the gadget, then modifies the contents so that one
variant has the shim and grub binaries in `EFI/boot/` and another
variant has the shim and grub binaries in `EFI/ubuntu/` and the fallback
binary in `EFI/boot/`.

After building a core image around that modified gadget, the VM is
booted and the test checks that the EFI variables are set correctly.
Then, the test modifies the gadget to match the other variant's initial
layout, and then installs the newly modified gadget. This should trigger
re-setting EFI boot variables as well.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Robert Ancell
Author Date: 2023-10-19 12:29:47 UTC

wrappers: install snapd .desktop files on core (#13078)

* wrappers: install snapd .desktop files on core

This is required for the session agent to work.

* wrappers: ensure /var/lib/snapd/desktop/applications exists in writeSnapdDesktopFilesOnCore

* Rename function to match go conventions

* Don't create desktop file dir

* wrappers: hard code the desktop files in case these are removed from snapd in the future

* Add test for snap-handle-link.desktop

* Add comment about not removing desktop files from the list

* Add comment to existing service file list stating that it can only be appended

---------

Co-authored-by: James Henstridge <james@jamesh.id.au>

Author: Oliver Calder
Author Date: 2023-09-26 14:03:11 UTC

osutil/epoll: remove unnecessary type from error variable

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-20 16:30:42 UTC

o/ifacestate/apparmorprompting: check that replied path pattern matches requested path

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-19 19:39:19 UTC

usersession/agent: only close session bus if non-nil

On Ubuntu 16.04, ssh sessions may not have a D-Bus session bus,
resulting in the `bus` field of the session agent being nil. If this is
the case, calling `s.bus.Close()` results in a nil pointer exception.
This commit adds a check of `s.bus` (like those found elsewhere in
session_agent.go) before calling `s.bus.Close()` during a session
shutdown.

Discovered-by: Andrew Phelps <andrew.phelps@canonical.com>
Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-15 03:50:25 UTC

boot: improved setting EFI boot variables on install

Fixed bugs (notably, now compare `varDevicePathStr` to `devicePathStr`
instead of `EfiShimFilePath`, which would never have matched), and no
longer delete EFI variables which point to a path which matches
`EfiShimFilePath` on a non-matching disk.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-11 14:46:23 UTC

prompting: merge duplicate requests

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-08 16:40:40 UTC

interfaces/builtin: custom-device add log message when basename rule applies to non-basename device

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-22 20:42:53 UTC

sandbox/apparmor/notify/listener: improved unit tests

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

sandbox/apparmor/notify/listener: improved unit tests for error handling

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-09-05 21:32:02 UTC

daemon: use `0x1E` consistently for record separator in prompting json-seq responses

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-30 15:09:46 UTC

o/ifacestate/apparmorprompting: handle reply with lifespan "single"

A reply with a lifespan of "single" should not create a new access rule.

Previously, such a reply created an access rule with a lifespan of
"single", which then expired after being used to satisfy one future
request. This was done to match the behaviour of creating a new access
rule with a lifepan of "single" directly by posting to the
`/v2/access-control/rules` endpoint with an action of "create".

Both as the result of a reply and of a direct rule creation, the idea of
a rule with a lifespan of "single" is a bit strange. In the latter
case, we may as well support this behaviour. In the former, however, I
think that the use in satisfying the corresponding request counts as the
"single" use for which a reply with a lifespan of "single" applies.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Robert Ancell
Author Date: 2023-09-01 04:32:58 UTC

interfaces: Allow snap-prompting-control interface access to snap metadata

Author: Oliver Calder
Author Date: 2023-08-31 03:34:26 UTC

interfaces/builtin: allow-auto-connection of `snap-prompting-control` -- TODO: revert!

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Robert Ancell
Author Date: 2023-08-31 02:11:00 UTC

prompting: Don't require polkit access for snap-prompting-control

Only snaps that are allowed to perform prompting will have this interface
connected. They will provide their own prompting and don't require polkit
to confirm.

Author: Oliver Calder
Author Date: 2023-08-30 22:40:39 UTC

prompting: support following all access rules for a user, without restriction by snap

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-30 15:09:46 UTC

o/ifacestate/apparmorprompting: handle reply with lifespan "single"

A reply with a lifespan of "single" should not create a new access rule.

Previously, such a reply created an access rule with a lifespan of
"single", which then expired after being used to satisfy one future
request. This was done to match the behaviour of creating a new access
rule with a lifepan of "single" directly by posting to the
`/v2/access-control/rules` endpoint with an action of "create".

Both as the result of a reply and of a direct rule creation, the idea of
a rule with a lifespan of "single" is a bit strange. In the latter
case, we may as well support this behaviour. In the former, however, I
think that the use in satisfying the corresponding request counts as the
"single" use for which a reply with a lifespan of "single" applies.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-29 03:40:15 UTC

o/ifacestate/apparmorprompting: clean trailing `/` from paths and path patterns

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-25 21:09:45 UTC

daemon: make `access_test.go` check both `snap-themes-control` and `snap-prompting-control` interfaces

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-25 19:14:04 UTC

Revert "prompting: Add snap-prompting-control interface"

Author: Oliver Calder
Author Date: 2023-08-24 22:19:37 UTC

o/ifacestate/apparmorprompting: added `omitempty` to json struct fields, matching SD121 spec

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-22 22:07:23 UTC

run-checks: make `golangci-lint` installation not interfere with system installation

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-22 20:42:53 UTC

sandbox/apparmor/notify/listener: improved unit tests

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-22 13:09:18 UTC

Merge branch 'master' into prompting-add-apparmor-package

Author: Oliver Calder
Author Date: 2023-08-21 15:29:08 UTC

gadget: remove testutil import in non-test code

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-15 03:11:45 UTC

daemon: add prompting endpoints for access control and prompt requests

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-15 03:06:12 UTC

sandbox/apparmor/notify: renamed `notifier` to `listener` as sub-package of `notify`

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-09 17:45:34 UTC

o/ifacestate/apparmorprompting/common: added early return from `RemovePermissionFromList()` if list is empty

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-08-09 17:31:12 UTC

o/ifacestate/apparmorprompting/common: replaced exported `AllFilePermissionsMask` with use of `IsValid()` method

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-07-31 23:12:41 UTC

gadget: remove unused private types after refactor

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-07-31 15:33:12 UTC

accessrules: fixed method calls which relied on go 1.20 (currently require go 1.18)

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-07-24 21:47:56 UTC

epoll: replaced `Errno` magic numbers with defined values

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-12 04:13:51 UTC

prompting: fixed typos to satisfy `./run-checks`

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-06-21 01:37:21 UTC

prompting/storage: fixed types in storage_test.go

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Michael Vogt
Author Date: 2023-06-14 14:14:17 UTC

Merge pull request #26 from olivercalder/apparmor-prompting-permission-handling-backend

prompting/storage: added per-permission decision handling

Author: Oliver Calder
Author Date: 2023-06-13 19:40:53 UTC

prompting/storage: replaced `reflect.DeepEqual` with test suite `DeepEquals`

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-06-13 16:12:48 UTC

daemon: add `DELETE` verb

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Michael Vogt
Author Date: 2023-06-05 14:19:44 UTC

Merge remote-tracking branch 'upstream/master' into mount-control-zfs-mount-options

Author: Oliver Calder
Author Date: 2023-05-25 02:36:32 UTC

cmd/snapd-aa-prompt-ui: fixed dbus field name for permission

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-23 21:58:33 UTC

interfaces/builtin: moved custom-device unique basename check

This change moves the check for whether all specified devices have
unique basenames out of `validateUDevTaggingRule()` (which is called
once for each udev rule) into `BeforePrepareSlot()`, immediately after
the list of device paths is assembled and each path validated. Thus, it
is only called once, before any rule validation begins.

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-23 17:33:42 UTC

interfaces/builtin: updated mount-control unit tests to reflect alphabetization

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-18 01:17:29 UTC

prompting/storage: added unit tests for Get()

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Michael Vogt
Author Date: 2023-05-17 07:57:55 UTC

Merge remote-tracking branch 'upstream/master' into commas-in-paths

Author: Oliver Calder
Author Date: 2023-05-16 17:02:45 UTC

interfaces/builtin: generalize handling for filesystems with colon-separated mount options

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Michael Vogt
Author Date: 2023-05-15 09:20:31 UTC

interfaces: make UDevConnectedPlug slightly more readable

Author: Oliver Calder
Author Date: 2023-05-12 04:13:51 UTC

prompting: fixed typos to satisfy `./run-checks`

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-04 12:33:09 UTC

cmd/snapd-aa-prompt-ui: fixed bugs in NameOwnerChanged handler

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-04 05:58:11 UTC

cmd/snapd-aa-prompt-ui: updated prompt to always send "allow-directory" to preserve existing behaviour

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>

Author: Oliver Calder
Author Date: 2023-05-03 08:15:07 UTC

snap/integrity/dmverity: fix comment formatting to satisfy run-checks

Signed-off-by: Oliver Calder <oliver.calder@canonical.com>