lp://staging/~jamesodhunt/upstart/bug-1447756-the-actual-fix
- Get this branch:
- bzr branch lp://staging/~jamesodhunt/upstart/bug-1447756-the-actual-fix
Branch merges
- Upstart Reviewers: Pending requested
-
Diff: 230 lines (+167/-3)3 files modifiedChangeLog (+18/-0)
init/log.c (+42/-0)
init/tests/test_log.c (+107/-3)
Related bugs
Bug #1447756: [SRU] segfault in log.c code causes phone reboot loops | Undecided | Fix Committed |
Related blueprints
Branch information
Recent revisions
- 1666. By James Hunt
-
* init/log.c:
- log_clear_unflushed( ): Handle logs on the unflushed list which
get flushed automatically by their corresponding NihIo before
a request to clear the unflushed list is made. This scenario
is triggered when a job which has spawned processes exits, but
where the spawned processes continue to run and then produce
output before the request to clear the unflushed list is made
(at the time the log partition becomes writable) but after the
log partition becomes writable (LP: #1447756).
* init/tests/test_log. c:
- test_log_new(): Added new test:
"ensure logger unflushed list ignores already flushed data".
- test_log_destroy(): Improved test
"ensure unflushed data moved to unflushed list with uid 0" by giving
the log a parent and checking parent handling behaviour. - 1665. By James Hunt
-
* init/log.c:
- Make log_flushed public to allow tests to test
log_handle_ unflushed( ) properly.
- log_handle_unflushed( ):
- Make log a child of the list entry and the latter a child of the
unflushed list.
- log_clear_unflushed( ):
- Ensure the list entry is freed along with the log to avoid an
invalid entry remaining in the list (LP: #1447756).
* init/tests/test_log. c:
- test_log_destroy(): Added new test:
- "ensure unflushed data moved to unflushed list with uid 0"
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/upstart