lp://staging/~fabien-morin/unifield-wm/sync-fm-sp-223

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

651. By Fabien MORIN on 2016-01-15

SP-223 [IMP] sorry for going back on this change again and again, but using
  limit=1 in combination with order='NO_ORDER' is more logic than using with
  count=True. This also not imply adding a new condition in the search and
  reusing existing code as much as possible. This is a minor modification and
  should not alter current behaviour and performances (or perhaps improve a
them
  just a bit as there is less if in the search)

650. By Fabien MORIN on 2016-01-13

SP-223 [FIX] revert r648. Because any_exist method introduction can be
    dangerous, as JFB said, it is possible that some upper definition of search
method may modify args, by-passing all search method with this any_exists can
be dangerous.

649. By Fabien MORIN on 2016-01-13

SP-223 [IMP] declare execution_date to avoid to have the case of some update
with a lower id have an execution_date after an higher id. Here is an example :

logs.keys() = [1,2,3,4]
update_ids = [1,2,3,4,5,6,7]

ids_not_in_logs = [5,6,7]
In this case, we will first write ids_not_in_logs [5,6,7] with current execution_date
and after that we will write logs.keys() [1,2,3,4]. This mean that the update
with id=1 will have an execution_date after the update with id=5.

This is not really a problem for normal work, but for performance measurement
this give negative execution time.

648. By Fabien MORIN on 2016-01-13

SP-223 [IMP] use the new any_exists method

647. By Fabien MORIN on 2016-01-13

SP-223 [IMP] remove one read as the data could be get from values, no need to
read them after the write.
Do not touch if no data changed (previous_values == new values)
Embedding if's not to do them more than one time when it is not necessary.

This revision will probably improve performances but some precaution need to be
taken and tests runned with it.

646. By Fabien MORIN on 2016-01-13

SP-223 [IMP] if self.info['error'] is '' set it to False instead of ''. This is
the default value and will permit not to sync in case
self.info['error'] is False on both current_value and previous_value (before it was
sync if the value was False before and '' after.

645. By Fabien MORIN on 2016-01-08

SP-223 [IMP] ids is already checked at the begening of this method, no need to
check it one more time

644. By Fabien MORIN on 2016-01-08

SP-223 [IMP] small changes, revert sorted behaviour as I'm not certain it keep
the old behaviour

643. By Fabien MORIN on 2016-01-07

SP-223 [FIX] second part of the previous revert to go back to orginal code

642. By Fabien MORIN on 2016-01-07

SP-223 [FIX] revert this change as it was not good. What we need here are the
new values, not the previous ones